Conversation
✅ No Blockers —
|
| kimi-code | glm | aggregate | |
|---|---|---|---|
| Readiness | 95 | 96 | 95 |
| Confidence | 95 | 98 | 95 |
| Correctness | 95 | 100 | 95 |
| Security | 100 | 100 | 100 |
| Testing | 100 | 90 | 90 |
| Architecture | 90 | 95 | 90 |
This PR is a minimal, targeted CI fix: it removes the fragile HEAD
1 version-diff logic in the release workflow and replaces it with a direct 'does this GitHub release already exist?' check. The root cause (merge commit parent already carrying the bumped version, causing silent skip) is correctly identified and fixed. CHANGELOG.md and package.json are updated appropriately. No runtime code was changed. | Read all 3 changed files in full. This is a version bump (0.15.0→0.15.1), CHANGELOG entry, and a workflow fix that removes a fragile HEAD1-based version diff in favor of a simple 'does the re
🟡 LOW Unnecessary fetch-depth: 2 in release workflow — .github/workflows/release.yml
Line 22:
fetch-depth: 2was required for the oldgit show HEAD~1:package.jsonlogic. The new code no longer referencesHEAD~1, so the fetch-depth override is unnecessary. It is harmless but can be removed for cleanliness.
tangletools · 2026-05-06T18:23:08Z · trace
tangletools
left a comment
There was a problem hiding this comment.
✅ Approved — 1 non-blocking finding
This PR is a minimal, targeted CI fix: it removes the fragile HEAD
1 version-diff logic in the release workflow and replaces it with a direct 'does this GitHub release already exist?' check. The root cause (merge commit parent already carrying the bumped version, causing silent skip) is correctly identified and fixed. CHANGELOG.md and package.json are updated appropriately. No runtime code was changed. | Read all 3 changed files in full. This is a version bump (0.15.0→0.15.1), CHANGELOG entry, and a workflow fix that removes a fragile HEAD1-based version diff in favor of a simple 'does the re
🟡 LOW Unnecessary fetch-depth: 2 in release workflow — .github/workflows/release.yml
Line 22:
fetch-depth: 2was required for the oldgit show HEAD~1:package.jsonlogic. The new code no longer referencesHEAD~1, so the fetch-depth override is unnecessary. It is harmless but can be removed for cleanliness.
tangletools · 2026-05-06T18:23:08Z · trace
Root cause
PR #36 (
tin/consume-ui-package) merged with a merge commit preserving inner commits. The release workflow'sHEAD~1diff compared against the PR's penultimate commit which already carried0.15.0inpackage.json— so the version-change check saw no diff,changed=false, and all publish steps were silently skipped despite the workflow reportingsuccess.Fix
HEAD~1diff withgh release viewprobe — if no GitHub release exists forv${NEW_VERSION}, publish fires. Idempotent: once a release exists, subsequent pushes skip; merge strategy no longer matters.Triggered by: #36