Skip to content

fix(release): republish 0.15.1; switch detection to release-existence probe#37

Merged
AtelyPham merged 2 commits intomainfrom
tin/republish-0.15.1-and-harden-release
May 6, 2026
Merged

fix(release): republish 0.15.1; switch detection to release-existence probe#37
AtelyPham merged 2 commits intomainfrom
tin/republish-0.15.1-and-harden-release

Conversation

@AtelyPham
Copy link
Copy Markdown
Contributor

Root cause

PR #36 (tin/consume-ui-package) merged with a merge commit preserving inner commits. The release workflow's HEAD~1 diff compared against the PR's penultimate commit which already carried 0.15.0 in package.json — so the version-change check saw no diff, changed=false, and all publish steps were silently skipped despite the workflow reporting success.

Fix

  1. Bump to 0.15.1 with CHANGELOG entry explaining the republish.
  2. Replace HEAD~1 diff with gh release view probe — if no GitHub release exists for v${NEW_VERSION}, publish fires. Idempotent: once a release exists, subsequent pushes skip; merge strategy no longer matters.

Triggered by: #36

@AtelyPham AtelyPham self-assigned this May 6, 2026
@github-project-automation github-project-automation Bot moved this to Not Started 🕧 in Tangle Universe May 6, 2026
@AtelyPham AtelyPham moved this from Not Started 🕧 to Building 🏗️ in Tangle Universe May 6, 2026
@AtelyPham AtelyPham requested a review from tangletools May 6, 2026 18:17
@tangletools
Copy link
Copy Markdown

tangletools commented May 6, 2026

✅ No Blockers — 9150e9d7

Readiness 95/100 · Confidence 95/100 · 1 finding (1 low)

kimi-code glm aggregate
Readiness 95 96 95
Confidence 95 98 95
Correctness 95 100 95
Security 100 100 100
Testing 100 90 90
Architecture 90 95 90

This PR is a minimal, targeted CI fix: it removes the fragile HEAD1 version-diff logic in the release workflow and replaces it with a direct 'does this GitHub release already exist?' check. The root cause (merge commit parent already carrying the bumped version, causing silent skip) is correctly identified and fixed. CHANGELOG.md and package.json are updated appropriately. No runtime code was changed. | Read all 3 changed files in full. This is a version bump (0.15.0→0.15.1), CHANGELOG entry, and a workflow fix that removes a fragile HEAD1-based version diff in favor of a simple 'does the re

🟡 LOW Unnecessary fetch-depth: 2 in release workflow — .github/workflows/release.yml

Line 22: fetch-depth: 2 was required for the old git show HEAD~1:package.json logic. The new code no longer references HEAD~1, so the fetch-depth override is unnecessary. It is harmless but can be removed for cleanliness.


tangletools · 2026-05-06T18:23:08Z · trace

Copy link
Copy Markdown

@tangletools tangletools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — 1 non-blocking finding

This PR is a minimal, targeted CI fix: it removes the fragile HEAD1 version-diff logic in the release workflow and replaces it with a direct 'does this GitHub release already exist?' check. The root cause (merge commit parent already carrying the bumped version, causing silent skip) is correctly identified and fixed. CHANGELOG.md and package.json are updated appropriately. No runtime code was changed. | Read all 3 changed files in full. This is a version bump (0.15.0→0.15.1), CHANGELOG entry, and a workflow fix that removes a fragile HEAD1-based version diff in favor of a simple 'does the re

🟡 LOW Unnecessary fetch-depth: 2 in release workflow — .github/workflows/release.yml

Line 22: fetch-depth: 2 was required for the old git show HEAD~1:package.json logic. The new code no longer references HEAD~1, so the fetch-depth override is unnecessary. It is harmless but can be removed for cleanliness.


tangletools · 2026-05-06T18:23:08Z · trace

@github-project-automation github-project-automation Bot moved this from Building 🏗️ to Completed ✅ in Tangle Universe May 6, 2026
@AtelyPham AtelyPham merged commit bd693d8 into main May 6, 2026
1 check passed
@AtelyPham AtelyPham deleted the tin/republish-0.15.1-and-harden-release branch May 6, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed ✅

Development

Successfully merging this pull request may close these issues.

2 participants