Repository navigation
Move the devcontainer pin when the matrix moves the lockfile - #78
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red. The build matrix published ten new digests in 23c16c5,containers/images.lock.jsonmoved, and.devcontainer/devcontainer.jsondid not, sotests/test_devcontainer.py::test_the_digest_is_one_the_build_matrix_publishedfails on every branch since. The failure has nothing to do with the branch it shows up on, which is how it was found.The lockfile and the devcontainer name one fact, so one command writes both.
tools.matrix.repinrewrites the"image"line from the lockfile row for the image the file already names, atPIN_ARCH, which is amd64 because Codespaces is. It is a pattern over the text and not a JSON round trip: eighteen lines of that file are a comment explaining the pin to a reader.matrix recordcalls it, so the workflow step that folds the published digests in also moves the pin.commit it if it movedstep now diffs and adds both files. Adding only the lockfile is the bug that produced this.repinwould write, which is the regression itself.The stale pin is updated to
sha256:65e31a4f..., the currentrel:amd64row.matrix digests --checkstill reports the two missingbootrows. That is the M2 second gate (#21) and not this.