fix(platform): repair the chat store and audit-lock tests after the merges - #3261
Merged
Conversation
…erges Three campaign PRs were each green on their own base but not together: #3230 deleted core/chat/turn_store.ts while #3245 imports its settleDeferredSendOnUserAppend — re-homed into domains/chat/store.ts, its only consumer. #3230 added a notifyThread call (and a test asserting the NOTIFY) on the chat_stream channel #3245 removed as listener-less — the call and the assertion go. #3246 put the audit chain head behind pg_advisory_xact_lock, which #3240's strict recording-tx tests (members/service, users/create-member) did not answer — they answer it now, as organizations/service.test.ts already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main went red after the campaign merges: three PRs were each CI-green on their own base but not together.
core/chat/turn_store.tswhile fix(platform): complete deferred sends and memories, prune dead chat doors #3245 importssettleDeferredSendOnUserAppendfrom it → the pure decorator is re-homed intodomains/chat/store.ts, its only consumer.notifyThreadcall inappendMessage(and a test asserting the NOTIFY) on thechat_streamchannel that fix(platform): complete deferred sends and memories, prune dead chat doors #3245 removed as listener-less (nothing LISTENs on it) → the call and thef.notifiedassertion go.pg_advisory_xact_lock; fix(platform): complete organization removal and member credential paths #3240's strict recording-tx tests (members/service.test.ts,users/create-member.test.ts) refused the unexpected SQL → they answer the lock SELECT with[], asorganizations/service.test.tsalready does.Gates observed (services/platform, on this tip)
bunx tsc --noEmit— exit 0 (main: 3 errors)bunx oxlint --type-aware— exit 0bunx vitest --run --project server—Test Files 547 passed (547)/Tests 6370 passed (6370)(main: 1 file / 2 tests failing plus the type errors)No behaviour change beyond restoring what each merged PR intended; no migrations, no locale keys.