fix(platform): default SANDBOX_URL so container workers reach the spawner - #3115
Merged
Conversation
…wner The 0.5 worker execs before env.sh, so session_client fell through to localhost:8003 and every agent start died with "fetch failed".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backend-workerexecs beforeenv.sh, soSANDBOX_URLnever defaulted tohttp://sandbox:8003.session_clientthen hitlocalhost:8003and every agent start died in ~20ms withthe agent run could not start: fetch failed(seen on demo05.tale.dev).SANDBOX_URLin the backend entrypoint, both compose pipelines (compose.yml+ CLI generator), and a freshtale init.env, and lock the alias in compose-parity.Test plan
bun test tools/cli/src/lib/compose/services/compose-parity.test.ts tools/cli/src/lib/config/ensure-env.test.tsqueued(session create reaches the spawner). Existing deploys can also setSANDBOX_URL=http://sandbox:8003in.envand recreatebackend-workerwithout waiting for a new image.