Skip to content

Extraction correctness fixes: QUALIFY scope, MERGE RETURNING, tuple SET, INSERT arity, GROUP BY ordinals#35

Merged
takaebato merged 11 commits into
masterfrom
review4-followups
Jun 27, 2026
Merged

Extraction correctness fixes: QUALIFY scope, MERGE RETURNING, tuple SET, INSERT arity, GROUP BY ordinals#35
takaebato merged 11 commits into
masterfrom
review4-followups

test: cover untested SQL constructs and public reference conversions

1c503c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 27, 2026 in 0s

94.87% (target 85.00%)

View this Pull Request on Codecov

94.87% (target 85.00%)

Details

Codecov Report

❌ Patch coverage is 90.68826% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.87%. Comparing base (2d14800) to head (1c503c7).

Files with missing lines Patch % Lines
sql-insight/src/reference.rs 86.48% 4 Missing and 1 partial ⚠️
sql-insight/src/resolver/binder/expr.rs 90.47% 4 Missing ⚠️
sql-insight/src/resolver/binder/query.rs 77.77% 4 Missing ⚠️
sql-insight/src/resolver/binder/statement.rs 96.46% 3 Missing and 1 partial ⚠️
sql-insight/src/resolver/binder.rs 86.36% 1 Missing and 2 partials ⚠️
sql-insight/src/resolver/origins.rs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   94.30%   94.87%   +0.57%     
==========================================
  Files          27       27              
  Lines        5054     5214     +160     
  Branches     5054     5214     +160     
==========================================
+ Hits         4766     4947     +181     
+ Misses        212      192      -20     
+ Partials       76       75       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.