Skip to content

feat(types): add fromName and subject params to SendPasswordResetEmailInput#157

Merged
k1LoW merged 1 commit intomainfrom
update-send-password-reset-email-types
Apr 1, 2026
Merged

feat(types): add fromName and subject params to SendPasswordResetEmailInput#157
k1LoW merged 1 commit intomainfrom
update-send-password-reset-email-types

Conversation

@k1LoW
Copy link
Copy Markdown
Contributor

@k1LoW k1LoW commented Apr 1, 2026

Summary

  • Add optional fromName and subject fields to SendPasswordResetEmailInput in tailor.idp types
  • fromName allows overriding the sender display name (defaults to 'Tailor Platform IdP')
  • subject allows overriding the email subject line (defaults to the localized default subject)

@k1LoW k1LoW requested a review from a team as a code owner April 1, 2026 01:54
@k1LoW k1LoW self-assigned this Apr 1, 2026
@k1LoW k1LoW added the enhancement New feature or request label Apr 1, 2026
Copy link
Copy Markdown
Contributor

@toiroakr toiroakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +366 to +367
/** The sender display name. Defaults to 'Tailor Platform IdP'. */
fromName?: string;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought senderName might be okay too, but I guess it's because of the email specs?

Copy link
Copy Markdown
Contributor Author

@k1LoW k1LoW Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromName is the display name portion of the "From" header (Display Name <address>). Since this field only overrides the display name, not the actual sender address, fromName is more precise than senderName. This also aligns with the upstream (platform-core-services) naming.

@k1LoW k1LoW merged commit 30d650e into main Apr 1, 2026
6 checks passed
@k1LoW k1LoW deleted the update-send-password-reset-email-types branch April 1, 2026 03:15
k1LoW added a commit that referenced this pull request Apr 1, 2026
k1LoW added a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants