Added static model support for the .forge.toml#3086
Open
joshuas99 wants to merge 2 commits intotailcallhq:mainfrom
Open
Added static model support for the .forge.toml#3086joshuas99 wants to merge 2 commits intotailcallhq:mainfrom
joshuas99 wants to merge 2 commits intotailcallhq:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
See my original issue and the initial feature request that I noted was related.
The key issue I noted was the documentation showed it should be possible to add a static model, but the capability was not yet there.
I needed static model support for myself as I was testing the new Qwen3.6 model. I went ahead and created a plan to add the support while still retaining the initial capability for the static
modelsURL that was a part of the[[providers]]definition in the schema.Project Structure Summary
This is taken directly from the implemented plan.
The implementation spans three key areas:
forge.schema.json): JSON Schema definition for configuration validationcrates/forge_config/src/config.rs): Rust struct definitions with Serde deserializationcrates/forge_repo/src/provider/provider_repo.rs): Internal model handling withModelsenumRelevant Files
forge.schema.json:613-689ProviderEntryschemamodelsaccepts onlystring | nullcrates/forge_config/src/config.rs:69-99ProviderEntrystructmodels: Option<String>crates/forge_repo/src/provider/provider_repo.rs:13-21ModelsenumUrlandHardcodedcrates/forge_domain/src/model.rs:23-38Modelstructcrates/forge_repo/src/provider/provider.jsonTarget State
Outcome
This fix worked for me to locally support model configuration parameters including crucially modifying the context windows when the values were not presented by oMLX.