refactor: replace unmaintained SSE dependencies to restore stream reliability#3036
Open
amitksingh1490 wants to merge 5 commits intomainfrom
Open
refactor: replace unmaintained SSE dependencies to restore stream reliability#3036amitksingh1490 wants to merge 5 commits intomainfrom
amitksingh1490 wants to merge 5 commits intomainfrom
Conversation
Why: our previous SSE dependencies had effectively stalled maintenance for about two years, and stream reliability issues (EOF handling, stalls, and provider-specific error surfacing) were becoming operational risk. This change moves the transport/repository stack to actively maintained components and aligns retry/error semantics so users get clear provider messages instead of ambiguous stream failures. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Fixes clippy::string_slice and clippy::indexing_slicing errors in: - forge_repo/src/provider/event.rs - forge_repo/src/provider/retry.rs - forge_repo/src/provider/sse_parser.rs Co-Authored-By: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the unmaintained SSE transport stack with maintained components to restore dependable streaming behavior and clear provider error reporting across OpenAI-compatible and Bedrock flows.
Context
Our prior streaming path depended on libraries and integration behavior that had effectively stagnated for roughly two years. As provider APIs evolved, this created increasing operational risk: stream stalls after reasoning, EOF/reconnect edge cases, and confusing surfaced errors (including cases where provider intent was obscured by generic wrapper messages).
This PR focuses on reducing that reliability risk and improving user trust in streaming outputs under normal and throttled conditions.
Changes
Why this matters
Testing
cargo +nightly fmt --all && cargo +nightly clippy --all-features --workspace --all-targets --fix --allow-dirty -- -D warningscargo nextest run --all-features --workspacecargo test -p forge_repo provider::bedrock::testscargo build