Feature: Delete streams#85
Open
ricksliu wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.delete [stream]Yes/no confirmation prompt that prints which streams get deleted
Deletes physical DB files and removes relevant ids from all three indexer tables
Other notes:
To print the streams being deleted, implemented a helper function
get_all_stream_names()which maps stream IDs to the original stream strings (i.e. stream + matchers). Unfortunately we don't actually store those original strings anywhere in the indexer so it has to reconstruct them.No concurrency/locking. Maybe we could wait for a exclusive lock on all physical files before deleting.