Conversation
Contributor
|
Yo @wjsutton this looks excellent. I will review this as soon as possible so its ready for TC'25 |
Contributor
|
Looks safe to me because of this line: I thought this might be a breaking change, but it seems like this line handles issues where datasource_luid() was not set, but it is present in env vars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR Title: Search datasources tool
Author: Will Sutton
Date of Review: April 3rd 2025
Summary
Added tools for LangGraph Agent to search datasources and switch it's default datasource_luid to one found from search
Functionality & Implementation
Adds two tools available for the agent use:
datasource_search, datasource_switchcontained withinexperimental\tools\search_datasource.pyIntegration
experimental\agents\demos\searchbuilding on the superstore agentsearch_agent_utils.pyto display the current datasource luidshared_state.pyinexperimental\agentshelps manage and update the datasource_luid fordatasource_qa.pytoolchromadband extracts details of all named datasources on the tableau sitedatasource_searchwill query the vector db and return a datasource luiddatasource_switchwill take this datasource luid and initiateanalyze_datasourceNotable changes to existing code
experimental\tools\datasource_qa.pyand similar functions now run using theshared_state.pyto receive dashboard luid rather than referring to environment variables, note on the initial run ofmain.pythe dashboard luid is set to the environment variable luid.main.pynow runs from using the search agent rather than superstore.enviroment.ymlnow includes chromadb