Allow objects to be passed into SelectField#1400
Open
unitedsoftwork wants to merge 6 commits intotabalinas:masterfrom
Open
Allow objects to be passed into SelectField#1400unitedsoftwork wants to merge 6 commits intotabalinas:masterfrom
unitedsoftwork wants to merge 6 commits intotabalinas:masterfrom
Conversation
tabalinas
requested changes
Aug 25, 2021
Owner
tabalinas
left a comment
There was a problem hiding this comment.
Thank you for the change!
Could we add a unit test for this new functionality?
Author
|
ah yes. tests lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this little bit of code we can allow the select field to receive an object rather than just an integer, this is very useful for when a REST API sends nested data rather than just ID's that are references to the data.
e.g
with the field set up like so:
Rather than
{ "id": 1, "name": "John Doe", "job": 1 }we can now pass something like this
{ "id": 1, "name": "John Doe", "job": { "title": "Manager", "id": 1 } }