fix(ai): pass system proxy and valid reasoning effort to Codex CLI#3463
Open
koco-co wants to merge 2 commits into
Open
fix(ai): pass system proxy and valid reasoning effort to Codex CLI#3463koco-co wants to merge 2 commits into
koco-co wants to merge 2 commits into
Conversation
koco-co
marked this pull request as ready for review
July 14, 2026 12:52
t8y2
requested changes
Jul 14, 2026
t8y2
left a comment
Owner
There was a problem hiding this comment.
Maintainer patch applied in f856fd3 to preserve inherited proxy environment settings and prevent the detected system proxy from overriding an existing lowercase proxy variable. The focused Codex CLI tests pass with the added regression coverage.
I'm still requesting changes for the reasoning-effort behavior. Mapping Minimal to low globally changes the requested reasoning level for models that do support minimal. Codex CLI accepts minimal; support is model-specific. Please handle the fallback based on the selected model's supported reasoning efforts rather than aliasing the setting for every Codex model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minimalreasoning setting to Codex CLI's supportedloweffortcodexCliEnvproxy values, including lowercase environment keysRoot cause
Two independent configuration mismatches affected GUI-launched Codex CLI requests:
model_reasoning_effort="minimal", while the selected Codex model rejects that value and acceptslow,medium,high, and related supported levels.Implementation
AiReasoningLevel::Minimalnow serializes aslowfor Codex CLI.HTTP_PROXYandHTTPS_PROXYonly when equivalent keys are absent.Verification
Rust checks
cargo fmt --all -- --check && git diff --check && CARGO_TARGET_DIR=/tmp/dbx-cargo-target cargo test -p dbx-core --lib— exit 0; 2000 declared: 1994 passed, 0 failed, 6 ignored, 0 filtered. The six ignored cases require external live databases.CARGO_TARGET_DIR=/tmp/dbx-cargo-target cargo clippy -p dbx-core --locked --all-targets— exit 0; existing warnings remain (73 library, 80 test-target warnings).Tauri development UI flow
codex-cli, modelgpt-5.6-luna, reasoningminimal, emptycodexCliEnv.HTTP_PROXY,HTTPS_PROXY, lowercase variants, andALL_PROXYexplicitly removed.只回复 E2E_PROXY_REASONING_OKthrough the AI panel athttp://localhost:1420.E2E_PROXY_REASONING_OKfromCodex CLI / gpt-5.6-luna.Packaged macOS debug app flow
pnpm tauri build --debug --bundles app --config /tmp/dbx-e2e-3457/tauri.e2e.conf.json -- --no-default-features— exit 0.DBX E2E 3457.appwith the same isolated configuration and all parent proxy variables removed.只回复 PACKAGED_PROXY_REASONING_OKthrough the packagedtauri://localhostUI.PACKAGED_PROXY_REASONING_OKfromCodex CLI / gpt-5.6-luna.The UI verification covers the reproduced macOS development and packaged-debug flows. It does not claim signed/notarized release validation or a Windows UI run.