Feature:支持清除 Oracle 兼容数据库的查询模式#3459
Merged
Merged
Conversation
t8y2
requested changes
Jul 14, 2026
t8y2
left a comment
Owner
There was a problem hiding this comment.
request changes: 清除 schema 后的会话重置需要和下一次查询执行串行化。
updateSchema 目前通过 void closeResultSession(...) 和 void closeClientConnectionSession(...) 发起异步关闭,然后立即返回并清空 schema。如果用户马上执行查询,后端仍可能在关闭请求移除旧 pool 前,使用相同的 tab client session ID 取得并复用旧会话。Oracle 的 CURRENT_SCHEMA 在整个 session 中持续有效,因此这条查询仍可能在之前选择的 schema 下执行。
请确保该 tab 的下一次查询会等待 session reset 完成,并补充一个回归测试:阻塞 close-client-session 响应,清除 schema 后立即执行查询,确认 execute-multi 只能在关闭完成后发出。
zipg
force-pushed
the
codex/fix-clear-query-schema
branch
from
July 14, 2026 15:54
b7f4626 to
cc4b98b
Compare
Contributor
Author
|
已按审核意见修复,提交:
验证结果:
|
Owner
|
Thanks for the contribution! Merged in 12b3c84, will be released in the next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动内容
验证
pnpm typecheckpnpm vitest run --maxWorkers=4:387 个测试文件、3110 项测试通过pnpm buildDBX_TEST,切换到TEST后会话模式变为TEST;关闭并重建查询会话后恢复为DBX_TEST