feat: support Oracle trigger editing in table structure editor#3456
feat: support Oracle trigger editing in table structure editor#3456mikodream wants to merge 2 commits into
Conversation
t8y2
left a comment
There was a problem hiding this comment.
I'm going to request changes for now. The current metadata and editor model cannot safely edit existing Oracle triggers.
-
Oracle's
TRIGGER_TYPEis returned as values such asBEFORE EACH ROW, whilecreate_trigger_sqlonly acceptsBEFOREorAFTER. The Oracle agent also does not return the trigger statement, so existing triggers open with an empty body. Even a simple existing row trigger therefore cannot be edited and saved correctly. -
Reconstructing the trigger from only timing, event, table, and body is lossy for valid Oracle triggers. Clauses such as multiple events,
UPDATE OF,REFERENCING,WHEN, statement-level/INSTEAD OFtriggers, and compound triggers are not preserved and can be silently removed after an edit.
Please load and edit the complete Oracle trigger source, or explicitly restrict editing to a safely detected subset while keeping unsupported triggers read-only. Add integration coverage using metadata values returned by a real Oracle instance, rather than only manually constructed BEFORE/UPDATE test data.
变更说明
支持oracle DDL操作
变更类型
[ x ] 新功能
Bug 修复
性能优化
代码重构
文档更新
CI / 构建