Pass in dynamic callbacks - #26
Draft
joshr4 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was attempting to use the
onEventcallback of theuseNostrEventshook, and ran into an issue where the callback cannot be updated. This was problematic, as my callback depended on my component's state, which changed over time. I successfully registered the callback, but as the callback was redefined on each render cycle, theuseNostrEventshook continued to use the initial callback that was referencing stale data.The solution I came up with was to monitor the
eventsarray returned byuseNostrEvents, and execute my callback on each new event that came in. Another approach that may work here is to allow the callback to be dynamically updated. This PR makes a change that may facilitate that.I still need to test out this change to verify it is working as expected.