chore: upgrade to new material icons library#1058
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marxtin
requested review from
birterohden,
fl0uW,
itscursedphil and
veldhaenchen
birterohden
reviewed
Aug 25, 2025
|
|
||
| // Handle component names that start with numbers by prefixing with 'Icon' | ||
| if (/^\d/.test(componentName)) { | ||
| componentName = `Icon${componentName}`; |
Member
There was a problem hiding this comment.
Vorher hießen die MaterialPeople bspw. jetzt würden die dann IconPeople heißen? Dann müssen wir ja alle Stellen anpassen?
Contributor
Author
There was a problem hiding this comment.
Hello, ich das hier erst mal vibe-gecoded, um so viel wie möglich am freitag zu schaffen. ch nehme mir das ganze heute natürlich nochmal vor. nicht alle stellen habe ich revised.
birterohden
reviewed
Aug 25, 2025
| const svgFiles = categoryFiles.reduce( | ||
| (allFiles, files) => [...allFiles, ...files], | ||
| [], | ||
| // Use the configured default style (e.g., 'filled') to maintain backward compatibility |
Member
There was a problem hiding this comment.
Wir nutzen an super vielen Stellen die Outlines Variante, also nicht gefüllt und das waren dann immer eigene Icons, wie macht man das jetzt?
Contributor
Author
There was a problem hiding this comment.
yes, ich werde das heute lösen :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist