Add a Legacy theme that mimics the pre-overhaul Dash colors - #177
Merged
Merged
Conversation
Adds a "Legacy" terminal palette that also reskins the app chrome to the old "Obsidian Console" look (neutral grey + orange), with light and dark variants that follow the Light/Dark mode toggle. - terminalThemes: legacyDark/legacyLightTheme palettes, a `legacy` grid entry, and a `legacy` branch in resolveTheme (old One-Dark/One-Light terminal colors) - index.css: `.light.legacy`/`.dark.legacy` chrome token blocks, plus a `.legacy`-scoped flat side-panel override (old Dash had no gradient) - App.tsx: toggle the `legacy` class on <html> when the Legacy palette is selected - SettingsModal: resolve the preview swatch via resolveTheme so Legacy follows light/dark, and tag it "auto" Scoped entirely to the Legacy theme; no change for other palettes. Co-Authored-By: Claude <noreply@anthropic.com> via Dash <dash@syv.ai>
simo787c
changed the title
Co-Authored-By: Claude <noreply@anthropic.com> via Dash <dash@syv.ai>
Collaborator
|
Fix CI errors and merge |
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The recent UI overhaul replaced Dash's original "Obsidian Console" palette (neutral grey + orange accent, One-Dark/One-Light terminals) with the current warm-paper / moonlight-blue look. Some users preferred the old colors.
This PR adds an opt-in Legacy theme that reproduces the old look — both the app chrome and the terminal — with light and dark variants that follow the existing Light/Dark mode toggle.
Legacy is implemented as a terminal-palette entry (alongside Dracula, Nord, …). Selecting it also reskins the app chrome via a
legacyclass on<html>; picking any other palette reverts the chrome to the standard Light/Dark theme. There is no behavioral change for any existing palette.Proposed changes
terminalThemes.ts— addlegacyDarkTheme/legacyLightTheme(old One-Dark / One-Light terminal colors), alegacyentry at the end ofTERMINAL_THEMES, and alegacybranch inresolveTheme.index.css— add.light.legacy/.dark.legacychrome token blocks (full token sets reproducing the old white+orange / grey+orange palette), plus a.legacy-scoped flat side-panel override (old Dash had no gradient on the side panels).App.tsx— toggle thelegacyclass on<html>when the Legacy palette is selected.SettingsModal.tsx— resolve the terminal-preview swatch throughresolveTheme(so the Legacy swatch follows Light/Dark) and tag it "auto".Scoped entirely to the Legacy theme — no other palette changes behavior.
Test plan
pnpm type-checkpasses; pre-commit hook (Prettier / ESLint / type-check) is clean.