Repository navigation
test(site): pin what each guestbook cell does that nothing else reaches - #96
Open
systemfsoftware-maker wants to merge 1 commit into
Open
systemfsoftware-maker wants to merge 1 commit into
systemfsoftware-maker wants to merge 1 commit into
Conversation
The journeys watch rendered pages, the property tests pin pure decisions and the store suite never runs a cell, so five composed contracts had no test: a stored state outside the three fails moderate with StoredStateInvalid and leaves the row as it was; an illegal event fails with IllegalTransition and writes nothing; a sign refusal writes nothing; moderating an unknown id fails EntryNotFound; and EntryMoved persists exactly the decided state. Each cell runs under Cell.provideContext over the in-memory store, bound the way the composition root binds it. Sabotaging either cell's refusal path turns its scenario red while every other suite stays green.
systemfsoftware-maker
added this pull request to stack #100
October 16, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The journeys watch rendered pages, the property tests pin pure decisions
and the store suite never runs a cell, so five composed contracts had no
test: a stored state outside the three fails moderate with
StoredStateInvalid and leaves the row as it was; an illegal event fails
with IllegalTransition and writes nothing; a sign refusal writes nothing;
moderating an unknown id fails EntryNotFound; and EntryMoved persists
exactly the decided state. Each cell runs under Cell.provideContext over
the in-memory store, bound the way the composition root binds it.
Sabotaging either cell's refusal path turns its scenario red while every
other suite stays green.
Verification
Gates exit 0; site test 26. Sabotage: moderate CommandRejected→TransitionConflict and sign persisting on refusal each turn one scenario red.
Layer of stack #100 (trunk
main), merge bottom-up.