Repository navigation
build(flake): lock the release toolchain at the release PR lookup fix - #136
Merged
Merged
Conversation
flake.lock moves the pnpm-release-management input from 1abf89a to fbf6171 (pnpm-release-management#49). At 1abf89a the release-tools in the dev shell list open pull requests with a bare head filter, which GitHub ignores, and take the first open PR as the release PR, so a local `github-release-management pr` would rewrite an unrelated PR (#128). No other lock node moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
flake.locknow locks thepnpm-release-managementinput atfbf617135160fbde74c64835d21dd918d13538d7(systemfsoftware/pnpm-release-management#49). It was at1abf89a. I did it with the override-input form:No other lock node moved. With the
pnpm-release-managementnode deleted from both files, the old and newflake.lockare identical.Why
At
1abf89a, the dev shell'srelease-toolslook up the release PR by passing a bare branch name as the head filter. GitHub ignores that filter, so the tools take the first open PR in the repo. That is how Dependabot #128 got overwritten. #49 asks forowner:branchand accepts only a PR whose head ref is the release branch in this repo's owner. CI's release workflow already runs the tools from its own revision (pnpm-release-management#42). This commit gives the local tools the same fix, and the push tomasterstarts the Release run.Evidence (local, through
nix develop)The compiled
github-release-managementin the dev shell contains${repo.owner}:${head}andowner.login.toLowerCase(), and noArray.head(pulls).No changeset intent: the changeset gate reports no publishable package changed.
After merge
The Release run on
mastershould conclude with phaseversion. It should open a new PR fromchangeset-release/master, or update the PR that already has that head, and leave every other open PR alone. No tag is created.