Repository navigation
fix(lint): satisfy clippy 1.99 assert_is_empty and sync Cargo.lock to 0.3.6 - #121
Merged
Merged
Conversation
… 0.3.6 rust-toolchain.toml tracks stable and the workspace denies clippy::all. Rust 1.99.0 (2026-09-28) added clippy::assert_is_empty, which rejects assert!(x.is_empty()); master CI and the v0.3.6 release run picked it up and failed at the clippy step. All ten sites now use assert_eq! against an explicitly typed empty Vec, so a failure prints the unexpected items. The version-packages commit (#120) bumped the crate to 0.3.6 without recording it in Cargo.lock; cargo rewrites the entry on any build. No changeset: the release planner resumes the untagged 0.3.6 publish only while no intents are pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
masterhas failed since #119 merged, and so did the v0.3.6 Release run, both at the clippy step. This PR makes clippy pass again, so the stalled 0.3.6 publish can resume.Why master broke after a green PR
rust-toolchain.tomlfollowsstable, and the workspace denies all ofclippy::all. Rust 1.99.0 shipped on 2026-09-28 with a new lint,clippy::assert_is_empty, that rejectsassert!(x.is_empty()). The runner image picked up the new toolchain between the two runs:masterafter merge, 10-01assert_is_emptyerrorsNone of the flagged lines were changed in #119. They were already on
masterand only started failing under the new lint.Changes
src/strip.rsandtests/{classify,strip,f1}.rsnow useassert_eq!against an explicitly typed emptyVec(or""for strings). A failure now prints the unexpected items instead of justfalse.Cargo.lock: recorded the crate as 0.3.6. chore(release): version packages #120 bumped the manifests without updating the lock, the same gap fix(cargo): record claude-code-comment-checker 0.3.4 in Cargo.lock #116 fixed for 0.3.4.Release
There's no changeset on purpose.
plan-release.tsonly choosespublishfor the untagged 0.3.6 while no intents are pending, so merging this resumes the v0.3.6 publish that failed.Verification
The one-shot gate (
cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test --all-targets) passes on both rustc 1.99.0 and the dev shell's 1.98.1, with 128 tests passing on each. Mutation testing wasn't run becausesrc/classify.rsis unchanged.Not addressed here: the toolchain still follows
stable, so the next stable release can add lints and break CI the same way.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.