Skip to content

Design updates to better match COSMIC#53

Merged
jackpot51 merged 4 commits intomasterfrom
cosmic-theme
Apr 15, 2026
Merged

Design updates to better match COSMIC#53
jackpot51 merged 4 commits intomasterfrom
cosmic-theme

Conversation

@jackpot51
Copy link
Copy Markdown
Member

image(1)
image(2)

@jackpot51 jackpot51 requested review from a team February 25, 2025 17:59
@jackpot51 jackpot51 self-assigned this Feb 25, 2025
@jacobgkau jacobgkau self-assigned this Feb 28, 2025
Copy link
Copy Markdown
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes the text a bit smaller, but it's still legible on both 1x and 2x scaled screens. It could be an accessibility concern.

lemp13 before/after:
1000020417
1000020416

addw2 before/after:
1000020407
1000020414

Open Sans does include ↑ and ↓ characters, so switching from that to the words Up and Down doesn't seem necessary. Despite Launch using the words, most keyboards include arrows. I don't think it's likely to result in any confusion, though.

I do want a sign-off from @system76/ux before we merge this. Better matching COSMIC means worse matching classic Pop!_OS, which is still what we currently ship as stable. (Not sure if this was intended to wait until closer to when COSMIC's ready.)

@maria-komarova
Copy link
Copy Markdown

Looks good to me. Yes, it will match current Pop!_OS worse but we can view it as the beginning of the transition.
One small thing could we round the buttons corner a little bit?

@leviport
Copy link
Copy Markdown
Member

For accessibility reasons, I'd feel a lot better about this if the text size was closer to the size it used to be.

@maria-komarova
Copy link
Copy Markdown

Good on my side to make it bigger.

@jackpot51
Copy link
Copy Markdown
Member Author

I rebased on master and reverted the font size changes

@jackpot51 jackpot51 requested a review from jacobgkau January 21, 2026 18:00
Copy link
Copy Markdown
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size is looking better now, much closer to what it was before.

lemp13:

Image

addw2:

Image

@maria-komarova asked in #53 (comment) if we could round the corners of the highlighted item a little. They appear to be completely squared off in faab466. Do we need further discussion about that?

@jackpot51
Copy link
Copy Markdown
Member Author

I set the border radius. To make it prettier we could include a manual image of the four corners.

@jackpot51 jackpot51 requested a review from jacobgkau April 14, 2026 18:31
Copy link
Copy Markdown
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what it's looking like now:

1000037275 1000037274

Looks good to me (checked all the pages). While the new corners aren't quite as smooth, it seems like their radius is more consistent between LoDPI and HiDPI, which is nice.

@jackpot51 jackpot51 merged commit 36accde into master Apr 15, 2026
1 check passed
@jackpot51 jackpot51 deleted the cosmic-theme branch April 15, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants