Skip to content

Fix read length handling #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 1 commit into from
Jun 2, 2026
Merged

Fix read length handling #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions control.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,9 @@ static ssize_t control_read(struct file *file,
size_t length,
loff_t *offset)
{
int len;
static const char *str = "Virtual V4L2 compatible camera device\n";
pr_debug("read %p %dB\n", buffer, (int) length);
len = strlen(str);
if (len < length)
len = length;
if (copy_to_user(buffer, str, len) != 0)
pr_warn("Failed to copy_to_user!");
return len;
return simple_read_from_buffer(buffer, length, offset, str, strlen(str));
}

static ssize_t control_write(struct file *file,
Expand Down
Loading