Conversation
The inner "except ... as e" for the error-log redirect send shadowed the outer send failure's "e", and Python deletes that binding when its except block exits. Once the redirect send also failed, reading e.message afterward raised UnboundLocalError, silently swallowing the original error and skipping the plain-text fallback send. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…vices sysblok-infra now treats sysblokbot-prod and sysblokbot-testing as independent deploy targets (separate Compose projects) instead of one shared project that got force-recreated on every deploy, restarting prod on dev-only pushes. Point each workflow's repository_dispatch at its own service name to match. Do not merge until the sysblok-infra side (branch fix/split-sysblokbot-deploy-services there) is deployed and the one-time data migration to the new /srv/sysblokbot-prod and /srv/sysblokbot-testing paths is done -- merging first would dispatch deploys to service directories that don't exist yet on the host. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ices fix: dispatch dev/master deploys to split sysblokbot-testing/prod services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/tg/sender.py: fixed anUnboundLocalErrorin the error-handling path — the innerexcept ... as efor the error-log redirect send shadowed the outer send failure'se, and Python deletes that binding when its except block exits. Once the redirect send also failed, readinge.messageafterward crashed, silently swallowing the original error and skipping the plain-text fallback send.publish_master.yml: now dispatchesservice: sysblokbot-prodinstead ofservice: sysblokbot, matching the sysblok-infra split (sysblok/sysblok-infra#32) that gives prod and testing independent Compose projects — previously every deploy (including dev-only ones) force-recreated both containers.Test plan
sysblokbot-testingrunning post-split at revision05c21ee(includes the sender.py fix), confirmed healthy via logsmasterpush builds:prod, dispatchesservice: sysblokbot-prod, andsysblokbot-proddeploys/restarts cleanly🤖 Generated with Claude Code