Use isUp() when checking server status to respect availability status#2
Open
jvalentini wants to merge 1 commit intosysadminblog:masterfrom
Open
Use isUp() when checking server status to respect availability status#2jvalentini wants to merge 1 commit intosysadminblog:masterfrom
jvalentini wants to merge 1 commit intosysadminblog:masterfrom
Conversation
when servers are set to DOWN state with setDown().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
isUp()when checking server status to respect availability status when servers are set toDOWNstate withsetDown().During testing of this server policy, I explicitly set my order
1server toDOWNusingsetDown()which resulting in the query timing out asupStatusdoes not respect availability status fromsetDown().