Handle unsaved IPAddress objects with a CIDR string in the address field properly#798
Merged
Handle unsaved IPAddress objects with a CIDR string in the address field properly#798
Conversation
peteeckel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #797
The problem occurs only under very specific conditions, i.e. when the creation of the
IPAddressobject is done within a script and a CIDR string instead of anetaddr.IPNetworkobject is passed to to theaddressfield.When saving, NetBox converts this field to an
netaddr.IPNetworkobject behind the scenes. However, as long as theIPAddressobject is not refreshed from the database, there is still a string in theaddressfield, which causes the NetBox DNS code to fail in several places.The safe bet is always to use an
IPNetworkobject, but this PR should catch the issue even if a CIDR string is used.