[feature] mentions#706
Conversation
There was a problem hiding this comment.
Your problem with the roomUsers is a problem with the room Model. I note this is due for a refactor...
Does that mean I can ignore it for now? |
for mor information see syphon-org#706 (comment)
for mor information see syphon-org#706 (comment)
…i/syphon into feature/mentions
Yes, I believe so. |
|
You can take advantage of |
| final bool loading = widget.sending; | ||
| final double maxInputHeight = replying ? height * 0.45 : height * 0.65; | ||
| final double maxMediaHeight = keyboardHeight > 0 ? keyboardHeight : height * 0.38; | ||
| final double maxInputHeight = |
There was a problem hiding this comment.
make sure your default column width is set to 110, it's the default for Syphon
| : 0), | ||
| topRight: Radius.circular(!replying | ||
| ? DEFAULT_BORDER_RADIUS | ||
| : 0), |
There was a problem hiding this comment.
lots of these updates are just column reduction, I'll review more once you've set the default to 110
I'll try to find time these weekend to find a way to make this work by default for whoever forks the project
It used to be very difficult to enforce similar to eslint, where it just requires the config to be local
|
Most of the requests I made above are styling changes. Happy to help make these - and again - find a way to automate some of this where you have no choice but to follow the convention. Dart / Flutter used to do a poor job at enforcement, where as other languages allow much more tooling around linting that makes it easier to just pull and auto format I'll take a look this week |
EdGeraghty
left a comment
EdGeraghty
left a comment
There was a problem hiding this comment.
So very close, now :)
|
I'm unable to test this
|
|
I invalidated all of my caches and built from scratch just to make sure |
|
Perhaps something wrong with your settings |
|
I will pull this branch and clean it up before reviewing @florian-sabonchi. No need to make changes just yet Aiming to have the 0.2.14 branch out next weekend and test the dev branch extensively throughout the week |
…, bugs addressed after refactor
|
@florian-sabonchi pushed a branch here targeting your PR! I've refactored what's needed and will approve this PR after the merge. Great work! :) |
refactor: cleaned up mentions branch
Hi, Thanks for your work. I merged your pull request seems that we have some merge Konflikts because long time ago i made the initial Pull Request |
4 participants
Types
Changes
Added a dialog that allows to select users of a room to mark them in the chat.
Attention! Known bug not all members of the room are currently loaded, unfortunately I can't find this bug. I have opened a pull request so that it is possible to review the code and possibly fix the bug.