Repository navigation
Harden/close auth review gaps - #33
Merged
Merged
Conversation
Revalidate sessions against the live user, hash session keys, and keep one outstanding magic link per user. Require a binding secret when one was issued, canonicalize client IPs, and cap send and verify failures. BREAKING CHANGE: Sessions and magic links from 0.3.0 no longer authenticate. Cookie defaults are __Host-session and __Host-ml-bind with a 7-day Max-Age. findUserById must return the live user or getSession ends the session.
Document live session checks, binding rules, and no-referrer verification responses. Development notes match in-memory unit tests.
Cleanup deletes only the merged dependency branch when no open pull request still uses that head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.