Skip to content

fix NullPointerException #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
x-Ai wants to merge 2 commits into
base: release
Choose a base branch
from
Open

fix NullPointerException #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316d7b2
fix NullPointerException
x-Ai Sep 29, 2025
7659857
fix NullPointerException
x-Ai Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extension/src/main/java/synfron/reshaper/burp/core/messages/ContentType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ public String getName() {
}

public static ContentType get(burp.api.montoya.http.message.ContentType contentType) {
if (contentType == null) {

@ddwightx ddwightx Sep 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return Unknown;
}
return switch (contentType) {
case AMF -> Amf;
case XML -> Xml;
Expand Down
2 changes: 1 addition & 1 deletion ...n/src/main/java/synfron/reshaper/burp/core/messages/entities/http/HttpRequestMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ public boolean isChanged() {

private void initialize() {
if (!initialized) {
initialized = true;
if (httpRequest == null) {
sanityCheckHeaders();
httpRequest = HttpRequest.httpRequest(ByteArray.byteArray(request));
}
if (!encoder.isUseDefault() && encoder.isAutoSet() && !getContentType().isTextBased()) {
encoder.setEncoding("default", true);
}
initialized = true;

@ddwightx ddwightx Sep 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give your thought process on this move?

@x-Ai x-Ai Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, A recursive loop materializes when the initialize() method invokes getContentType(), which in turn calls back to initialize(). To resolve this circular dependency, the initialized = true; statement should be relocated to the very top of the if (!initialized) block within the initialize() method. This strategic placement dismantles the recursive cycle; upon its subsequent invocation by getContentType(), the initialize() method will encounter the pre-set flag and return immediately, thereby preempting the redundant execution of the initialization logic

}
}

Expand Down