Fix workers() not respecting user-specified order#112
Merged
Conversation
…isableDefaultWorkers()
c236a18 to
cb21d97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #111
MBConfig::workers()does not respect the user-specified worker order. When users calldisableDefaultWorkers()and then register workers in a specific order viaworkers(), the default workers (TagVersion, PushTag) always run first.Root cause
config/config.phpregisters default workers (TagVersionReleaseWorker, PushTagReleaseWorker) first. WhenMBConfig::workers()later calls$services->set(SameClass), it replaces the definition but PHP arrays preserve the original key position — so the workers stay at the front of the container's definitions array regardless of the user's intended order.Additionally, replacing the definition causes the
monorepo.default_workertag to be lost, makingRemoveDefaultWorkersCompilerPassunable to find and remove them.Fix
MBConfig::workers()now registers services with unique IDs (user_release_worker.{index}) instead of using the FQCN, so they are appended to the end of the definitions array in the user's specified order.RemoveDefaultWorkersCompilerPassnow also removes default workers whose class overlaps with user-registered workers (even withoutdisableDefaultWorkers()), preventing duplicates.Test coverage
workers()calldisableDefaultWorkers()onlydisableDefaultWorkers()+workers([TagVersion])workers([Custom, TagVersion, PushTag])withoutdisableDefaultWorkers()disableDefaultWorkers()+workers([Custom, TagVersion, PushTag])