[Caspar] Minor fix: Export CASPAR_MIN_ARCH and fix CUDA architecture list in Caspar template#463
Open
tordnat wants to merge 1 commit into
Open
Conversation
tordnat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CASPAR_MIN_ARCH was previously a local CMake variable, invisible to parent projects consuming Caspar via FetchContent. This change makes it a CACHE INTERNAL variable so downstream consumers (e.g. COLMAP) can read it after FetchContent_MakeAvailable(caspar) without hardcoding the value.
Also fixes the CMAKE_CUDA_ARCHITECTURES list: the previous 75 80 86 89 75-virtual generated PTX for all four architectures and emitted compute_75 twice. The corrected list 75 80-real 86-real 89-real generates SASS for all and PTX only from sm_75, matching the stated intent.