Feature alpine images - #41
Open
symric wants to merge 10 commits into
Open
Conversation
nglasl
approved these changes
Feb 27, 2020
nglasl
left a comment
nglasl
left a comment
Contributor
There was a problem hiding this comment.
Dropped a couple of comments below, but nothing that should hold this up.
| xsl \ | ||
| zip \ | ||
| && pecl install redis-4.0.1 \ | ||
| && pecl install xdebug \ |
Contributor
There was a problem hiding this comment.
Minor, this one doesn't have a version specified.
| COPY php.ini /usr/local/etc/php/php.ini | ||
|
|
||
|
|
||
| COPY xdebug.ini /usr/local/etc/php/conf.d/xdebug.ini |
Contributor
There was a problem hiding this comment.
Also minor, this one has two empty new lines above it compared to the others.
| @@ -0,0 +1,11 @@ | |||
| xdebug.remote_enable=on | |||
Contributor
There was a problem hiding this comment.
The xdebug.ini for each version doesn't match, seems like this one has the most recent changes while the others don't. I assume we should be making them all consistent, can we just have a single xdebug.ini?
Contributor
There was a problem hiding this comment.
@symric just a reminder on this before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains currently used alpine images which mirror the ubuntu images