fix: repetitive YouTube embeds and utterances sections in each page#13
Open
digital-carver wants to merge 1 commit intosylvaticus:mainfrom
Open
fix: repetitive YouTube embeds and utterances sections in each page#13digital-carver wants to merge 1 commit intosylvaticus:mainfrom
digital-carver wants to merge 1 commit intosylvaticus:mainfrom
Conversation
Author
|
I see now that these sections are generated in code in https://github.com/sylvaticus/SPMLJ/blob/main/makedoc.jl . So fixing this in the markdown is not the solution I guess? I've not looked at the code too deeply, but maybe the problem is when doing Line 196 in 8bb0257 origContent already has a YouTube embed, this step adds another redundant one? So every time the docs are built, another copy of the YouTube embeds div and utterances div are added in? That seems a likely explanation for why these pages end up this way.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of the pages have repeated embeds of the same YouTube videos - for eg., the INTRO page https://sylvaticus.github.io/SPMLJ/stable/00_-_INTRO_-_Introduction_julia_ml/0003_-_Introduction_to_Julia.html has six copies of the same
divcontaining the same "Julia overview" video embed.Similarly, the utterances comment section is also shown multiple times in each page because it's div also has redundant copies in the HTML.
This PR removes the repeated copies, leaving one youtube embed div and one utterances section in each case as it should be.