fix(ui): keep workspace notices clear of the composer - #271
Draft
Dixith-dev wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the controller warning sitting behind the composer in Workbench.
The notice was absolutely positioned at the bottom-right with
z-30, while the composer usesz-[100]. Since both were anchored to the same edge, the composer won the stacking order and hid most of the message.I moved workspace notices to the top-right, just below the pane toolbar, and kept them above the workspace layers. That keeps the warning visible without covering the input. I also added a small regression test for the positioning.
Tested with:
npm run check