Add soft-fail-version-check toggle to warn (not error) on untested Swift versions#745
Open
escii wants to merge 6 commits into
Open
Add soft-fail-version-check toggle to warn (not error) on untested Swift versions#745escii wants to merge 6 commits into
escii wants to merge 6 commits into
Conversation
… swift version errors of versions that are outside the hardcoded versions.
This reverts commit 791fcf8.
|
@fwal what do you think about this workaround? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new boolean input, soft-fail-version-check, which defaults to false. When set to true, the action will:
This makes it possible to consume patch/minor releases (e.g. 6.1.1) as soon as they’re available upstream, without having to wait for the action’s static list to be updated. #743 #706 #683 #672
Changes:
action.yml
src/swift-versions.ts
Tests:
Added a matrix job in our test workflow to verify all three behaviors:
You can see the matrix runs here:
https://github.com/sonderformat-llc/setup-swift-test/actions/runs/15975074977