Repository navigation
fix(feedback): point widget at same-origin feedback path - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-api-urltohttps://api.admin.dev.sweetrpg.com/api/0/feedback- a host that doesn't exist on this platformdev.sweetrpg.comhost as main-web, at/api/0/admin/<route>(seedocs/deployment-conventions.md's "API Ingress path versioning"), so this call is same-origin, not cross-originFEEDBACK_API_URL's default to the correct path-only value:/api/0/admin/feedbackConfirmed against the live dev endpoint:
https://api.admin.dev.sweetrpg.com/...-> 404 (host doesn't route anywhere meaningful)https://dev.sweetrpg.com/api/0/admin/feedback-> 200{"status":"accepted"}(The
ALLOWED_ORIGINSCORS config added to admin-api in sweetrpg/admin-api#95 turns out to be unnecessary - same-origin requests don't need CORS - but it's harmless to leave in place.)Test plan
cargo fmt --check,cargo clippy --all-targets,cargo testpass