Repository navigation
feat: make JEI an optional dependency - #98
Merged
Merged
Conversation
Add hover providers for vanilla and JEI to get item information Add item picker text box to queue manager Refs: #97
Add hover providers for vanilla and JEI to get item information Add item picker text box to queue manager Refs: #97
Facilitates manual verification that the mod runs cleanly without JEI installed (task 7.3). Restore this line after testing is complete. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HoverItemProviderabstraction andHoverProviderRegistryso item-under-mouse resolution is pluggable; JEI is no longer required at runtime.VanillaSlotHoverProvider(priority 0) that readsAbstractContainerScreen.hoveredSlotvia a new access-transformer entry; addsJeiHoverProvider(priority 100) that reads the JEI ingredient overlay — registered only fromCTPlugin.onRuntimeAvailable, keeping all JEI API imports isolated toCTPluginandJeiHoverProvider.CTPlugin(JEI-gated) toClientEventHandler.onClientLoginso managers initialise on world join regardless of whether JEI is present.QueueManagementScreen(search box + scrollable list backed byForgeRegistries.ITEMS) so players can queue items without JEI installed.mods.tomlJEI dependency frommandatory=true→mandatory=false; updates CurseForge and Modrinth build declarations tooptional.Test plan
build.gradle): noNoClassDefFoundErroron startup; slot-hover-add works; native picker loads items, search filters, scroll works, click adds to queue; managers load on world joinruntimeOnly fg.deobf("mezz.jei:jei-${jei_version}")inbuild.gradleafter no-JEI testing is completeNotes
Closes #97.
The
runtimeOnlyJEI line inbuild.gradleis temporarily commented out to facilitate no-JEI dev testing (see task 7.3). Restore it before or after merge once testing is confirmed.🤖 Generated with Claude Code