Skip to content

Fix Telegram connect email enumeration and support signup via Telegram#398

Merged
techeng322 merged 1 commit into
mainfrom
techengme/myc-5003-telegram-connect-flow-leaks-whether-an-email-has-an-in
Jul 9, 2026
Merged

Fix Telegram connect email enumeration and support signup via Telegram#398
techeng322 merged 1 commit into
mainfrom
techengme/myc-5003-telegram-connect-flow-leaks-whether-an-email-has-an-in

Conversation

@techeng322

Copy link
Copy Markdown
Collaborator

Summary

  • connectTelegramToAccount no longer reveals up front whether a submitted email has a matching In Process account — it always sends a verification code and replies with the same message, whether or not a match was found. This closes an email-enumeration gap where anyone could probe arbitrary emails against the bot to learn which ones are registered.
  • verifyTelegramCode now only acts on the match (or its absence) after the code is verified:
    • Matched → links the Telegram username to the existing artist, as before.
    • Unmatched → provisions a Privy embedded wallet (ensurePrivySocialWallet) and creates a new artist (getOrCreateArtist, reusing the same helper used by the onchain mint flows), then connects the Telegram username to it — completing signup directly from Telegram instead of requiring web signup first.

Test plan

  • pnpm vitest run — 1472/1472 passing
  • pnpm exec tsc --noEmit — no new type errors introduced

🤖 Generated with Claude Code

…legram

connectTelegramToAccount previously revealed whether an email had an In
Process account before verifying ownership, letting anyone probe arbitrary
emails to learn which ones are registered. It now always sends a
verification code and replies identically regardless of a match.

verifyTelegramCode only reveals (or acts on) the match after the code is
confirmed: when no artist was found, it now provisions a Privy embedded
wallet and a new artist via the existing getOrCreateArtist helper, then
connects the Telegram username to it — completing signup directly from
Telegram instead of requiring web signup first.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
in-process-api Ready Ready Preview Jul 9, 2026 12:49am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@techeng322, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 58c516be-46d6-4e6e-9b7d-461d7065cee7

📥 Commits

Reviewing files that changed from the base of the PR and between 6daa21d and c267b1d.

📒 Files selected for processing (5)
  • src/lib/telegram/chat/__tests__/connectTelegramToAccount.test.ts
  • src/lib/telegram/chat/__tests__/verifyTelegramCode.test.ts
  • src/lib/telegram/chat/connectTelegramToAccount.ts
  • src/lib/telegram/chat/getPendingCode.ts
  • src/lib/telegram/chat/verifyTelegramCode.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch techengme/myc-5003-telegram-connect-flow-leaks-whether-an-email-has-an-in

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@techeng322 techeng322 merged commit cd391b4 into main Jul 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant