Fix Telegram connect email enumeration and support signup via Telegram#398
Conversation
…legram connectTelegramToAccount previously revealed whether an email had an In Process account before verifying ownership, letting anyone probe arbitrary emails to learn which ones are registered. It now always sends a verification code and replies identically regardless of a match. verifyTelegramCode only reveals (or acts on) the match after the code is confirmed: when no artist was found, it now provisions a Privy embedded wallet and a new artist via the existing getOrCreateArtist helper, then connects the Telegram username to it — completing signup directly from Telegram instead of requiring web signup first. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
connectTelegramToAccountno longer reveals up front whether a submitted email has a matching In Process account — it always sends a verification code and replies with the same message, whether or not a match was found. This closes an email-enumeration gap where anyone could probe arbitrary emails against the bot to learn which ones are registered.verifyTelegramCodenow only acts on the match (or its absence) after the code is verified:ensurePrivySocialWallet) and creates a new artist (getOrCreateArtist, reusing the same helper used by the onchain mint flows), then connects the Telegram username to it — completing signup directly from Telegram instead of requiring web signup first.Test plan
pnpm vitest run— 1472/1472 passingpnpm exec tsc --noEmit— no new type errors introduced🤖 Generated with Claude Code