feat(tui): Warp-quiet landing and timeline - #6
Conversation
Benchmark: Warp CLI. The old splash stacked three framed boxes (banner card, command table, zsh TIP) before the first prompt; the timeline stamped every line with a clock and a DBG conversation-id row. - Splash: drop frames/gauge/tabs entirely. Figlet art, one dim meta line (version · agents · font), agent flock chips greedily wrapped to terminal width so all 17 stay visible. - Command sheet: one dim hint line (/ for commands · : agents · ! for shell) replaces the framed table; zsh TIP box removed. - Timeline: no per-line clock, dim gutter; plain mode loses its clock too. Chips keep TOOL/SKIL/AGNT/ACT/DONE lanes. - REPL: DBG 'Initialize <uuid>' conversation rows no longer print. - Spinner: '· Ctrl+C to interrupt' suffix dropped — tick + elapsed + label only. Co-Authored-By: AimeeCodes <noreply@aimeecodes.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe PR simplifies the terminal landing page and timeline to reduce repeated chrome and metadata.
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking test-structure issue in the rewritten splash test. The runtime presentation changes preserve their relevant width and output behavior, but the splash test uses partial substring assertions instead of the repository-required named fixture, actual, and expected structure with a whole-value assertion. Files Needing Attention: crates/aimee_main/src/banner.rs
|
| Filename | Overview |
|---|---|
| crates/aimee_main/src/banner.rs | Reworks the splash layout and command hints; the modified splash test violates the repository’s required test structure and relies on partial assertions. |
| crates/aimee_main/src/title_display.rs | Removes timestamps from colored and plain title formatting while preserving labels, titles, subtitles, and category styling. |
| crates/aimee_main/src/ui.rs | Suppresses the cosmetic conversation initialization/continuation timeline entry as described by the PR. |
| crates/aimee_spinner/src/lib.rs | Removes the interruption suffix while maintaining consistent visible-width accounting for spinner lines. |
Reviews (1): Last reviewed commit: "feat(tui): Warp-quiet landing and timeli..." | Re-trigger Greptile
| fn test_render_splash_quiet_landing() { | ||
| let area = splash_area(); | ||
| let mut buf = Buffer::empty(area); | ||
| render_splash(&mut buf, area); | ||
| let actual = buffer_text(&buf); | ||
| assert!(actual.contains("CLI agent flock")); | ||
| assert!(actual.contains("Aimee Codes")); | ||
| assert!(actual.contains("🍑")); | ||
| assert!(actual.contains("LOOP")); | ||
| // Meta line + two flock rows; no frame chrome. | ||
| assert!(actual.contains("agents")); | ||
| assert!(actual.contains("JetBrains Mono")); | ||
| // Row 1 leads with the loop trio. | ||
| assert!(actual.contains(":aimee")); | ||
| assert!(actual.contains(":muse")); | ||
| assert!(actual.contains(":sage")); | ||
| // Row 2 carries the tail of the flock (17 agents split across 2 rows). | ||
| assert!(actual.contains(":plat-sre") || actual.contains(":plat-cloud")); | ||
| assert!(actual.contains(":fe-ui") || actual.contains("fe-ui")); | ||
| assert!(actual.contains("specialists") || actual.contains("agents")); | ||
| assert!(!actual.contains('╭')); | ||
| assert!(!actual.contains('╰')); | ||
| assert_eq!(agent_chip_count(), 17); | ||
| } |
There was a problem hiding this comment.
Splash test uses partial assertions
The rewritten test checks selected substrings without the repository-required named fixture, actual, and expected steps or a whole-value assertion. This allows unasserted chips or malformed portions of the landing output to pass unnoticed.
Rule Used: # AGENTS.md
House rules for coding agents in the ... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Benchmark: Warp CLI. The goal is that nothing stands between the operator and the work: no frames, no chrome, no repeated metadata.
/ for commands · : agents · ! for shell).HH:MM:SSstamp and a bright gutter;DBG Initialize <uuid>printed on session start. Clock removed from both color and plain render, gutter dimmed, conversation-id row dropped (still available via:info). TOOL/SKIL/AGNT/ACT/DONE lanes unchanged.· Ctrl+C to interrupton every tick replaced by tick + elapsed + label only.Test Plan
cargo test -p aimee_main -p aimee_spinner: 379 passed, 0 failed (banner splash test now asserts frame glyphs absent AND tail chips like:plat-srepresent)cargo clippy -p aimee_main -p aimee_spinner --all-targets -- -D warnings: cleanCo-Authored-By: AimeeCodes noreply@aimeecodes.dev