Closed
Conversation
|
Hi @marqh -- This is not the main fork of this repository. I'm happy to merge new changes in this fork to the actual main fork (katyhuff/python-testing), but it would be much simpler if you re-issue this PR to the main fork (https://github.com/katyhuff/python-testing). Would you mind if we close this PR and conduct the review over in the main one? |
Author
I have created if we're happy to move discussions there, we can close this one |
|
Thanks! Much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@katyhuff @gvwilson
I have been through this module, erviewing and considering; I like the content. I would like to introduce the core library module
unittestalongside the testing options presented.I find
unittestreally useful and lots of new and learning developers are likely to come across it if they work with other people's code.I have also moved the 'edge cases' page to the end, as it seemed something of a sideline to me (and saved me from too much renumbering).
These are ideas, I'm really keen to discuss them and adapt them if they are interesting for you.
I have not built the content, so the html may be out of sync or missing
all the best
mark