Skip to content

refactor(es/minifier): Dead code - #12392

Merged
Donny/강동윤 (kdy1) merged 2 commits into
swc-project:mainfrom
Austaras:main
Sep 22, 2026
Merged

Donny/강동윤 (kdy1) merged 2 commits into
swc-project:mainfrom
Austaras:main

Conversation

@Austaras

@Austaras Austaras commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

Description:
Address multiple issues found in code review.

BREAKING CHANGE:

Related issue (if exists):
Related #12330 #12259 #12232

@Austaras
Austaras requested a review from a team as a code owner September 19, 2026 19:00
@changeset-bot

changeset-bot Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a1d20b6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

} catch (error) {
return sideEffect();
}
} catch (error) {}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually safe.

@codspeed

codspeed Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 2.92%

⚡ 1 improved benchmark
✅ 199 untouched benchmarks
⏩ 67 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ es/large/minify/libraries/terser 457.8 ms 444.8 ms +2.92%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Austaras:main (a1d20b6) with main (c392686)

Open in CodSpeed

Footnotes

  1. 67 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@kdy1
Donny/강동윤 (kdy1) requested a review from a team as a code owner September 20, 2026 01:15

@kdy1 Donny/강동윤 (kdy1) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1
Donny/강동윤 (kdy1) merged commit bbdc059 into swc-project:main Sep 22, 2026
68 checks passed
@github-actions github-actions Bot modified the milestones: Planned, v1.16.12 Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants