'Number Tapa' tab option

[gavrielhirsch]

This is very convenient when constructing a Tapa puzzle. I tested locally that it works, here is one example screenshot. I also found the CONTRIBUTING.md instructions a bit confusing, so I tried to improve them a bit.

[gavrielhirsch]

@swaroopg92 for some reason it won't let me add you as a reviewer. So pinging you in the comments instead.

[swaroopg92]

@gavrielhirsch Thanks. Will take a look. There is one minor challenge, Number Tapa is not available in Solver Mode, and being in the dropdown might confuse, so need to think of a way to handle that. Currently, all the modes under Tab are available in both Setting/Solver mode.

[gavrielhirsch]

Oh I see, I didn't realize that since setter solution mode has it. But that totally makes sense as a concern around adding it. I'll defer to you as to whether there's a clean way to add this to the codebase, and if not I can close this.

[gavrielhirsch]

Also perhaps worth mentioning, I did actually also want the solver to be able to place Tapa clues, as I was making a variant where the clues were not initially present on the grid.

I feel like there are often these sorts of variants that involve solving using modes that are typically only needed for setting. I wonder if there could be an option where all of the modes are potentially available in solver mode, but many are off by default. But the setter can enable extra ones for the solver if they want to.

I could create an issue suggesting it

[davmillar]

@gavrielhirsch do you feel confident making that change to enable that mode for solving, or is it beyond your comfort level?

@swaroopg92 if you're okay with it, I'd be happy to pick up where OP left off and make that possible -- let me know what you think.

[swaroopg92]

@davmillar If you have clarity on the discussion, feel free to go ahead and complete this. The immediate solution, I believe an option for the setter to enable all the modes for the solver.
Said that the ideal solution would be to implement a way for the setter to customize the solution modes selection (Currently, we have PenpaLite/Tab for mode level, but it would be great to have something 2 levels down, which is sub-mode level and style level too for selection). But this is an ambitious and challenging task.

[swaroopg92]

Tagging the corresponding Issue here #96