Merged
Conversation
Move expression lowering and helper parsing into a top-level dwarf_expr module. Parser, index, and objfile code now share the same gimli operation walker. Replace the CFI byte parser with shared operation lowering. This keeps unsupported CFA expressions fail-closed while adding coverage for constu, consts, and deref operations.
Move DW_OP_entry_value recovery and call-site fallback handling into entry_value.rs. The main lowering path now delegates entry-value decisions instead of carrying the full caller recovery chain inline. Keep existing full-resolution and soft fallback behavior unchanged while moving the entry-value specific tests with the implementation.
Centralize hard, fallback, and silent-false handling for DWARF expression modes so parse error behavior is explicit at each call site.
Move caller-side target, parameter, and call-value lowering into dwarf_expr::call_site so block indexing no longer owns DWARF op parsing or call-site fallback behavior.
Move CFA expression lowering and storage-address discovery into the shared dwarf_expr module so CFI and fast-parser callers no longer own expression operation parsing details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor introduces a dedicated
dwarf_exprmodule as the shared home for DWARF expression parsing, scanning, error policy, and consumer-specific lowering.The goal is to stop spreading DWARF opcode parsing across parser/index/semantics code, and make each expression consumer declare its own mode and fallback behavior explicitly.