Conversation
Fix the doubling of the copy-to-clipboard icon by removing the inner svg element, and just leaving the button background. Allow the copy button to shrink to being invisible by removing its padding. Clean up the unused CopyIcon component.
| @@ -13,8 +13,6 @@ | |||
| render() { | |||
| let { getComponent } = this.props | |||
Contributor
There was a problem hiding this comment.
Suggested change
| let { getComponent } = this.props |
| } | ||
|
|
||
| static propTypes = { | ||
| getComponent: PropTypes.func.isRequired, |
11 tasks
Contributor
|
Hi @Azquelt 👋 thank you for the fix! The doubled icon issue was a real pain point, and your diagnosis was spot on 🏅 We needed to get this out today as part of a planned release, so we've cherry-picked your commit and opened a superseding PR (#11050) on our side. We also took the opportunity to migrate the affected component to TypeScript while we were in there Thanks again for the contribution, and sorry we couldn't wait for this PR to go through the normal review cycle |
Author
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fixes #11046
How Has This Been Tested?
Tested manually in Firefox 155 and Chrome 153
Ran
npm run cy:cito check existing tests were not impacted.Screenshots (if appropriate):
Operation:
Curl command:
Response body:
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests