[needs review] sweep sweep/tags-2026-08-11-8: 3 tag fix(es) across 2 squad(s) - #690
Closed
swackhamer wants to merge 5 commits into
Closed
[needs review] sweep sweep/tags-2026-08-11-8: 3 tag fix(es) across 2 squad(s)#690swackhamer wants to merge 5 commits into
swackhamer wants to merge 5 commits into
Conversation
Format: DJVU
Tag: DjVu:Note
Sample: /tmp/oxidex-exiftool-cache/combined-samples/DjVu.djvu
Exiftool-Value: 'Must escape double quotes (") and backslashes (\\)'
Oxidex-Value: 'Must escape double quotes (") and backslashes (\\)'
Verified: recheck-pass gaps=1->0
Worker: tail-9
Format: APE Tag: Composite:Duration Sample: /tmp/oxidex-exiftool-cache/combined-samples/APE.ape Exiftool-Value: '2.64 s' Oxidex-Value: '2.64 s' Perl-Ref: APE.pm Verified: recheck-pass gaps=1->0 Worker: tail-5
Format: BPG Tag: XMP:ComponentsConfiguration Sample: /tmp/oxidex-exiftool-cache/combined-samples/BPG.bpg Exiftool-Value: 'Y, Cb, Cr, -' Oxidex-Value: 'Y, Cb, Cr, -' Perl-Ref: Exif.pm Verified: recheck-pass gaps=1->0 Worker: xmp-1
Worker-authored Rust reaches this branch semantically validated but never style-checked: validate_fix_commit.py, the per-commit merger check and the post-merge recheck all assert behaviour (gap deltas, no duplicate emissions, no unexplained oxidex-only keys) and none of them look at formatting. CI's "Lint & Audit" job runs `cargo fmt --all -- --check`, so an unformatted sweep branch fails CI by construction. Measured on PR #124 (branch sweep/tags-2026-07-26-1, the first sweep PR ever opened): CI run 30186389305 -- "Build & Test" success, "Lint & Audit" failure, and the failing step is literally `Run cargo fmt --all -- --check`. Kept as a separate commit so the tag-fix diffs stay readable.
Collaborator
Author
swackhamer
added a commit
that referenced
this pull request
Aug 11, 2026
…ouched Follow-up to #691. Measured 2026-08-11 in production: PR #692 duplicated #690 (byte-identical diffs, md5-verified) -- the #691 fix's own full-tree comparison missed it, because #690's branch was cut BEFORE #691 itself landed on origin/main, so it legitimately lacks the scripts/ changes #691 added. #692's branch, cut after #691 merged, carries those changes. A raw `diff --quiet <candidate>..HEAD` sees that unrelated drift as "different" and can never again match #690, no matter how many more times the same tag gap gets re-solved identically -- and the same defeat recurs for every future round whenever ANY unrelated commit lands on main while a sweep PR sits open, which given "the fleet publishes, it never merges" is routine. Fix: scope the comparison to `git diff --name-only origin_ref..HEAD` -- the paths THIS round's own squad merges actually touched -- instead of a full-tree diff. That isolates the tag-fix content from incidental history the two branches don't share. New regression test reproduces the exact #692-vs-#690 shape: an unrelated commit lands on main between when the open PR's branch was cut and when the new round's branch is cut, with the identical tag fix on both. Confirmed the test fails against the unversioned (pre-fix) code and passes with it. Full suite: 102 + 240 tests green.
swackhamer
added a commit
that referenced
this pull request
Aug 11, 2026
…ouched (#693) Follow-up to #691. Measured 2026-08-11 in production: PR #692 duplicated #690 (byte-identical diffs, md5-verified) -- the #691 fix's own full-tree comparison missed it, because #690's branch was cut BEFORE #691 itself landed on origin/main, so it legitimately lacks the scripts/ changes #691 added. #692's branch, cut after #691 merged, carries those changes. A raw `diff --quiet <candidate>..HEAD` sees that unrelated drift as "different" and can never again match #690, no matter how many more times the same tag gap gets re-solved identically -- and the same defeat recurs for every future round whenever ANY unrelated commit lands on main while a sweep PR sits open, which given "the fleet publishes, it never merges" is routine. Fix: scope the comparison to `git diff --name-only origin_ref..HEAD` -- the paths THIS round's own squad merges actually touched -- instead of a full-tree diff. That isolates the tag-fix content from incidental history the two branches don't share. New regression test reproduces the exact #692-vs-#690 shape: an unrelated commit lands on main between when the open PR's branch was cut and when the new round's branch is cut, with the identical tag fix on both. Confirmed the test fails against the unversioned (pre-fix) code and passes with it. Full suite: 102 + 240 tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep sweep/tags-2026-08-11-8
Evidence table
Judgment queue
No commits in this sweep require judgment-queue review -- everything ships mechanically.