Add Docker workflow for backend image build #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamStaijen
reviewed
Nov 27, 2025
| REGISTRY: ghcr.io | ||
| NAMESPACE: ${{ github.repository_owner }} | ||
| IMAGE_NAME: committee-clash-backend | ||
| IMAGE_TAG: "latest${{ github.ref == 'refs/heads/main' && '' || '-dev' }}" # TODO does not support versioning as of yet |
Member
There was a problem hiding this comment.
misschien branch-(pipelineid/pipeline-hash) (ik weet even niet hoe github dat doet, maar in gitlab is het $CI_PIPELINE_ID
Member
There was a problem hiding this comment.
een hash is niet incremental, maar zolang we aas gebruijken in de pipeline en de versie doorsturen is dat denk ik prima. Lijkt me wel goed om versies immutable te houden, en dus iets ever changing met lage kans op collissie als een hash of incrementing pipelime id te pakken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.