Repository navigation
fix: keep the uneval replacer typed under nodenext module resolution - #215
Closed
NotAFlightRisk wants to merge 1 commit into
Closed
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f13307a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Superseded by #225, which makes the same fix and switches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
moduleResolution: nodenext(ornode16) in your tsconfig, the replacer you pass tounevallost its types in 6.0.2. Put the README's replacer example throughstrictand you getParameter 'value' implicitly has an 'any' type, then the same again forjs.The import for the replacer type is the ony one in
src/with no.json the end. Since #209 that path gets copied as-is into the publisheduneval.d.ts, wherenodenextwon't resolve it. Bundler resolution isn't effected. That's what the type check here runs on, so it never showed up.