-
-
Notifications
You must be signed in to change notification settings - Fork 105
chore: update esrap
#620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: update esrap
#620
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
25d0bbf
chore: update `esrap`
manuel3108 c5aa975
Merge remote-tracking branch 'origin/main' into chore/esrap-2
manuel3108 9394c80
use esrap pkg.pr.new
manuel3108 79f262e
fix `svelte-kit` adapter addon
manuel3108 7c0c0d2
remove useless comment
manuel3108 f41da14
fix eslint
manuel3108 7307cc4
fix eslint
manuel3108 6df65fc
add changed tests
manuel3108 ae78455
thats ok too
manuel3108 23d569d
Merge branch 'main' into chore/esrap-2
manuel3108 1982ac4
those are ok as well
manuel3108 62444cc
fix last failing test
manuel3108 d871736
Merge branch 'main' into chore/esrap-2
manuel3108 0b55155
update esrap
manuel3108 54685d8
adapt to new api
manuel3108 0e56b56
improvements
manuel3108 a89a0e9
cleanup
manuel3108 4efbc25
remove useless comment
manuel3108 15d3400
Update packages/core/tooling/index.ts
manuel3108 c3ca656
Merge branch 'chore/esrap-2' of https://github.com/sveltejs/cli into …
manuel3108 7160300
re-add quote style
manuel3108 748cc4e
using esrap 2.2.1
jycouet d7ff4b2
simplifying?
jycouet 9ef38e3
good enough?
jycouet 2e6b85d
simplify
jycouet 8053314
add & remove
jycouet 44d7a85
api?
jycouet 061e94b
Merge branch 'main' of github.com:sveltejs/cli into chore/esrap-2
jycouet 3afb161
manual snapshot review OK
jycouet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 1 addition & 4 deletions
5
packages/cli/tests/snapshots/create-with-all-addons/playwright.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,6 @@ | ||
| import { defineConfig } from '@playwright/test'; | ||
|
|
||
| export default defineConfig({ | ||
| webServer: { | ||
| command: 'npm run build && npm run preview', | ||
| port: 4173 | ||
| }, | ||
| webServer: { command: 'npm run build && npm run preview', port: 4173 }, | ||
| testDir: 'e2e' | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,14 @@ | ||
| import { common, type AstTypes } from '@sveltejs/cli-core/js'; | ||
| import { common, type Comments, type AstTypes } from '@sveltejs/cli-core/js'; | ||
|
|
||
| export function run(ast: AstTypes.Program): void { | ||
| export function run(ast: AstTypes.Program, comments: Comments): void { | ||
| const functionDeclaration = ast.body[0] as AstTypes.FunctionDeclaration; | ||
|
|
||
| common.addJsDocComment(functionDeclaration, { | ||
| common.addJsDocComment(functionDeclaration, comments, { | ||
| params: { 'import("$lib/paraglide/runtime").AvailableLanguageTag': 'newLanguage' } | ||
| }); | ||
|
|
||
| // Adding 2 times the same comment should not add it twice! | ||
| common.addJsDocComment(functionDeclaration, comments, { | ||
| params: { 'import("$lib/paraglide/runtime").AvailableLanguageTag': 'newLanguage' } | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1 @@ | ||
| /** @type {number} */ | ||
| const foo = 42; | ||
| /** @type {number} */ const foo = 42; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,9 @@ | ||
| const empty = {}; | ||
| const created = { foo: 1, bar: 'string' }; | ||
|
|
||
| // prettier-ignore | ||
| const created2 = { | ||
| foo: 1, | ||
| bar: 'string', | ||
| object: { foo: 'hello', nested: { bar: 'world' } }, | ||
| array: [ | ||
| 123, | ||
| 'hello', | ||
| { foo: 'bar', bool: true }, | ||
| [456, '789'] | ||
| ] | ||
| array: [123, 'hello', { foo: 'bar', bool: true }, [456, '789']] | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 8 additions & 1 deletion
9
packages/core/tests/js/object/ensure-nested-property/output.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,8 @@ | ||
| const test = { a: { /** a comment */ keep: 'you', b: { c: '007' } } }; | ||
| const test = { | ||
| a: { | ||
| /** a comment */ | ||
| keep: 'you', | ||
|
|
||
| b: { c: '007' } | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| const test = { /** a comment */ foo: 2, bar: 'string2', lorem: false }; | ||
| const test = { | ||
| /** a comment */ | ||
| foo: 2, | ||
|
|
||
| bar: 'string2', | ||
| lorem: false | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| const test = { /*a comment updated*/ foo: 1, /*aka: bond, james bond*/ james: '007' }; | ||
| const test = { | ||
| /** a comment */ | ||
| foo: 1, | ||
|
|
||
| james: '007' | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.