Implement path traversal protection and rate limiting#136
Open
ThilakesB wants to merge 1 commit into
Open
Conversation
Added path traversal protection to file upload handling and re-enabled rate limiting for the verify chain endpoint.
There was a problem hiding this comment.
Pull request overview
This PR strengthens the FastAPI service’s defenses by hardening file-path handling for the SSE analysis endpoint and restoring request throttling on the chain verification endpoint.
Changes:
- Added path traversal protection to
/analyze-processby resolving and constrainingfile_pathtoUPLOAD_DIR. - Updated
/analyze-processto analyze the validatedsafe_pathinstead of the raw client-suppliedfile_path. - Re-enabled SlowAPI rate limiting on
/verify-chain(30/minute).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+301
to
+307
| safe_path = os.path.realpath(file_path) | ||
| upload_dir_real = os.path.realpath(UPLOAD_DIR) | ||
| if not safe_path.startswith(upload_dir_real + os.sep): | ||
| raise HTTPException( | ||
| status_code=400, | ||
| detail="Invalid file path. Access outside upload directory is not permitted." | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added path traversal protection to file upload handling and re-enabled rate limiting for the verify chain endpoint.