Fix users.json caching, race condition, and atomic writes#118
Open
sabhishek13-py wants to merge 1 commit into
Open
Fix users.json caching, race condition, and atomic writes#118sabhishek13-py wants to merge 1 commit into
sabhishek13-py wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing issue : #114
This PR fixes issues related to repeated file reads, race conditions, and unsafe writes in user handling.
Changes:
Added in-memory caching for users.json to eliminate repeated disk I/O
Implemented thread-safe locking to prevent race conditions during concurrent access
Introduced atomic file write pattern using temporary file replacement
Ensured safe handling of shared in-memory state
Impact:
Prevents data loss during concurrent registrations
Improves performance by reducing unnecessary file reads
Ensures data consistency and integrity