test(applied): pin block-transposition adjacency in every shared layer (#373) - #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #373.
Adds
review_soundness_fixes::block_transposition_needs_adjacency_in_every_shared_layertocatgraph-applied/tests/smc_nf_regression.rs: a fixture where a braid-carrying component separates two free components' runs in 2 of their 3 shared layers, asserting the exactnf()output. Production diff: 0 lines (git diff --stat 27be055..HEAD:tests/smc_nf_regression.rs+92,CHANGELOG.md+7,docs/SMC-NF-RECONCILIATION.md±1).Premise re-scoped at the STOP (owner call, recorded on #373): at
27be055theb1 == a2deletion reddens 6 tests in debug and 4 in release via corpus statistics; this test is the narrow, targeted oracle.Falsification (closing review, Sonnet
rust-v2:falsifying-reviewer,/tmp/audit-reports/G5-T6/close-review.md)b1 == a2inadjacent_runs(smc_nf.rs:2148)block_transposition_needs_adjacency_in_every_shared_layerdebug_assert!smc_nf.rs:2041(30/31 pass)assert_eq!(smc_nf_regression.rs:772):[Identity(1),Braid(1,1)],[G,G,Eta,F],[Eps,Eps,F,G],[Eps,Identity(1)]vs expected[Identity(1),Braid(1,1)],[F,G,G,Eta],[G,Eps,Eps,F],[Identity(1),Eps](30/31 pass)blocks_are_adjacentdecides on the first shared layer onlyRound 1 (lane, Opus) ran on
2f07e0cand its findings were applied; the closing review found one minor (a backtick span wrapped across a line in the CHANGELOG bullet), fixed in the final docs-only commit, which is unreviewed.Gates (pristine copy, closing review)
cargo nextest run -p catgraph-applied: 670 passed / 0 failed / 12 skipped.cargo clippy -p catgraph-applied --all-targets -- -D warnings: clean.cargo fmt --all --check: clean.🤖 Generated with Claude Code